fix(tables): Handle None events in recovery process#657
Open
level09 wants to merge 2 commits intofaust-streaming:masterfrom
Open
fix(tables): Handle None events in recovery process#657level09 wants to merge 2 commits intofaust-streaming:masterfrom
level09 wants to merge 2 commits intofaust-streaming:masterfrom
Conversation
Adds proper handling for None events in the changelog recovery process to prevent processing attempts on None events from the changelog queue. The fix silently skips None events and avoids busy loops when there are no active partitions or tables to recover. Improves stability of the recovery process by gracefully handling edge cases without adding unnecessary logging in production environments.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 102 102
Lines 11100 11100
Branches 1196 1196
=======================================
Hits 10444 10444
Misses 557 557
Partials 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Remove trailing whitespace and fix indentation to resolve CI check failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
_slurp_changelogsinfaust/faust/tables/recovery.pymethod in the recovery process doesn't properly handle None events that can occasionally be received from the changelog queue. When a None event is encountered, the code attempts to process it, which leads to errors since None doesn't have the expected attributes and methods.Solution
This PR adds a simple check at the beginning of event processing to detect and skip None events. The implementation:
Benefits
Testing
Tested in a production environment with Kafka where None events were occasionally being received from the changelog queue. The fix successfully prevents errors and maintains stable operation.