fixed StreamT annotations, TPorTopicSet can also be optional#660
Open
tworedz wants to merge 1 commit intofaust-streaming:masterfrom
Open
fixed StreamT annotations, TPorTopicSet can also be optional#660tworedz wants to merge 1 commit intofaust-streaming:masterfrom
tworedz wants to merge 1 commit intofaust-streaming:masterfrom
Conversation
Author
|
please review @wbarnha |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 94.09% 94.09%
=======================================
Files 102 102
Lines 11100 11100
Branches 1196 1196
=======================================
Hits 10444 10444
Misses 557 557
Partials 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wbarnha
reviewed
Jul 11, 2025
Member
wbarnha
left a comment
There was a problem hiding this comment.
Thanks for the PR! Most of the changes look good for merge, I am a bit surprised that TPorTopicSet was not already annotated with Optional. I will look closer at the code to make sure this is proper.
Author
|
Thanks! Seems that pypy doesn't like my changes, btw. Is it because of me or they were failing before? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Before submitting this pull request, please review our contributing
guidelines.
Description
StreamTclass.EventTclass.Noneas a documentation saying (https://faust-streaming.github.io/faust/reference/faust.app.html#faust.app.App.commit)__iter__/__aiter__methods onStreamT. And it makes sense, because it is extendingAsyncIterable, which already implements__aiter__.__iter__was just redundant here and broke typing.