Skip to content

Conversation

@taybin
Copy link

@taybin taybin commented Oct 13, 2021

This adds support for running tests in python 3.10.

Taybin Rutkin added 8 commits October 13, 2021 09:26
Note that this doesn’t change the parameters of functions.  They still 
accept loop arguments, even if they are unused.  Changing the API to
account for unused variables will come in a later commit.
@taybin taybin force-pushed the python3.10_support branch from 2dea637 to 89dd79f Compare October 13, 2021 17:18
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2021

Codecov Report

Merging #11 (2ee2cc0) into master (5994429) will not change coverage.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files          28       28           
  Lines        4031     4031           
  Branches      449      449           
=======================================
  Hits         3824     3824           
  Misses        188      188           
  Partials       19       19           
Impacted Files Coverage Δ
mode/services.py 97.89% <ø> (ø)
mode/supervisors.py 100.00% <ø> (ø)
mode/utils/logging.py 90.37% <50.00%> (ø)
mode/__init__.py 100.00% <100.00%> (ø)
mode/threads.py 94.42% <100.00%> (ø)
mode/utils/times.py 97.27% <100.00%> (ø)
mode/worker.py 97.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5994429...2ee2cc0. Read the comment docs.

@taybin taybin force-pushed the python3.10_support branch from 2ee2cc0 to 79dd630 Compare October 13, 2021 18:47
@taybin taybin requested a review from max-k October 13, 2021 18:55
@taybin taybin self-assigned this Oct 13, 2021
@taybin taybin merged commit 4aee4cd into faust-streaming:master Oct 14, 2021
@taybin taybin deleted the python3.10_support branch October 14, 2021 13:41
@patkivikram
Copy link

@max-k can you give @taybin and @patkivikram release privileges for mode-streaming on pypi

@dennis-weyland-by
Copy link

Push @max-k, a 3.10 compatible release would really be appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants