This repository was archived by the owner on Sep 28, 2023. It is now read-only.
Update React Native 0.29 #79
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 26, 2016 16:01
React Native v0.28 `StatusBarIOS` is deprecated.
Android showing error, now
undefined is not a function(evaluating)
'StatusBarIOS.setStyle('defalut')')
Fix :
StatusBarIOS.setStyle to StatusBar.setBarStyle
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
dstnation
changed the title
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
ghost
added
the
Fix Warning for React Native 0.28 - replce deprecated components - Add key props for [WARNING : Each child in an array or iterator should have a unique "key" prop.] - Add renderRow funtion for [WARNING : Failed propType: Required prop `renderRow` was not specified in `ListView`.] - ...
dstnation
changed the title
added 3 commits
June 26, 2016 23:52
|
@dstnation Thank you! This was great help. I hope it gets merged soon... |
| StatusBarIOS && StatusBarIOS.setStyle('light-content'); | ||
| StatusBar && StatusBar.setBarStyle('light-content'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Just started making this PR - thanks @dstnation 👍 don't have to do it now
fix, React-native V0.29
update react-native-code-push v1.13.2-beta
update react-native-code-push v1.13.2-beta
CallbackManager to Application static member
CallbackManager to Application static member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React Native v0.28
StatusBarIOSis deprecated.Android showing error, now
undefined is not a function(evaluating)
'StatusBarIOS.setStyle('defalut')')
Fix :
StatusBarIOS.setStyle to StatusBar.setBarStyle