Migrate TUI logic to SDK and remove TUI #588
Conversation
Migrated business logic from the deprecated TUI into the core SDK: - `Job` model: Added `is_terminal`, `is_successful`, `is_failed` properties. - `SubjectsEndpoint`: Added `list_by_site` and `async_list_by_site` for filtering. - `FormDesignerClient`: Added input validation to `save_form`. Removed the TUI application: - Deleted `imednet/tui` directory. - Removed `textual` dependency from `pyproject.toml`. - Updated CLI and examples to reflect removal. Added verification tests in `tests/unit/test_tui_migration.py`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Migrated business logic from the deprecated TUI into the core SDK: - `Job` model: Added `is_terminal`, `is_successful`, `is_failed` properties. - `SubjectsEndpoint`: Added `list_by_site` and `async_list_by_site` for filtering. - `FormDesignerClient`: Added input validation to `save_form`. Removed the TUI application: - Deleted `imednet/tui` directory. - Removed `textual` dependency from `pyproject.toml`. - Updated CLI and examples to reflect removal. Added verification tests in `tests/unit/test_tui_migration.py`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Frederick de Ruiter <127706008+fderuiter@users.noreply.github.com>
1 participant
This PR migrates essential logic from the TUI (Job status interpretation, Subject filtering, Form validation) into the core SDK to preserve functionality before removing the TUI entirely. It removes the
imednet/tuimodule and thetextualdependency, significantly reducing the package weight. New tests verify the migrated logic.PR created automatically by Jules for task 1375357816672136346 started by @fderuiter