Refactor Endpoints to Reduce Duplication #610
Conversation
Extract shared logic in `RecordsEndpoint` and `SubjectsEndpoint` to reduce duplication between sync and async methods. * `RecordsEndpoint`: Created `_prepare_create_request` to handle validation, header building, and path construction. * `SubjectsEndpoint`: Created `_filter_by_site` to handle site ID filtering logic. This adheres to DRY principles and improves maintainability. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Refactored
RecordsEndpointandSubjectsEndpointto eliminate code duplication between synchronous and asynchronous methods._prepare_create_request. This simplifiescreateandasync_createmethods and ensures consistent behavior._filter_by_site, ensuring that the filtering logic (including type handling for site IDs) is consistent acrosslist_by_siteandasync_list_by_site.These changes are structural only and preserve existing behavior, as verified by the test suite.
PR created automatically by Jules for task 734452701826851884 started by @fderuiter