🧹 Polish: Deduplicate record creation logic #613
Conversation
Extracted `_prepare_create_request` helper method in `imednet/endpoints/records.py` to handle validation, header building, and path construction. This removes duplication between `create` and `async_create` methods. Verified with existing tests in `tests/unit/endpoints/test_records_endpoint.py` and `tests/unit/endpoints/test_records_async.py`. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💩 Smell: Duplicate logic in
createandasync_createmethods ofRecordsEndpoint(validation, header building, path construction).✨ Polish: Extracted this shared logic into a
_prepare_create_requesthelper method.📉 Reduction: Reduced duplicated code blocks, ensuring consistency between sync and async implementations.
🛡️ Safety: Verified with full test suite - NO LOGIC CHANGES. All existing tests passed.
PR created automatically by Jules for task 4400060822178732712 started by @fderuiter