Skip to content

Refactor: Epidemiology safety and Physics determinism #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
fderuiter wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Refactor: Epidemiology safety and Physics determinism #374

fderuiter wants to merge 2 commits into from

Conversation

@fderuiter
Copy link
Owner

@fderuiter fderuiter commented Jan 29, 2026

This PR addresses critical technical debt in the math_explorer crate.

  1. Epidemiology Safety: Eliminated a potential panic in SIRModel by introducing proper error handling for invalid reaction indices. GillespieSolver now propagates these errors.
  2. Physics Determinism: Refactored the Ising model simulation to use a MetropolisSolver with injected RNG. This allows for deterministic testing and better adherence to SOLID principles. The old API is deprecated but backward compatible.
  3. Refactor Journal: Documented the addressed debt in .jules/refactor.md.

All changes verified with tests and clippy.

PR created automatically by Jules for task 18130922781650952795 started by @fderuiter

@fderuiter @google-labs-jules
Refactor: Epidemiology safety and Physics determinism
6cbc24b 
- Replaced `panic!` in `SIRModel::react` with `Result<_, EpidemiologyError>`.
- Updated `GillespieSolver` to propagate errors safely.
- Introduced `IsingSolver` trait and `MetropolisSolver` struct to decouple RNG from `SpinLattice`.
- Added `new_with_rng` to `SpinLattice` and deterministic tests for Ising model.
- Deprecated legacy `metropolis_step` and `evolve` methods on `SpinLattice`.
- Updated journal with debt entries.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

google-labs-jules bot commented Jan 29, 2026

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@fderuiter @google-labs-jules
Fix doc tests for Epidemiology and Ising models
65c6d22 
- Updated `GillespieSolver` doc test to unwrap `Result`.
- Updated `SpinLattice` doc test to use `MetropolisSolver` API and increased steps to ensure convergence.
- Verified all doc tests pass.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fderuiter