outo backup #646
Closed
outo backup #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto backup we have added auto backup the app will ask user first if he want to auto backup, if user click 'Yes' the feature is on.
Owner
federicoiosue
left a comment
federicoiosue
left a comment
There was a problem hiding this comment.
Hi @marwaothman,
thanks for your contribution but this code can't be merged for many reasons:
- Missing both unit and UI tests
- The whole code greatly increases technical debt due to a lot of thing, many of these are: code repetition, missing exception handling, hard-coded text strings, preferences management in main thread, commented code rows.
You could try to work on these things. Another thing that could help you could be to work on the specific feature branch (as stated into the README the approach is gitflow) called autobackup.
federicoiosue
force-pushed
the
develop
branch
from
9198924 to
7844ad1
Compare
federicoiosue
force-pushed
the
develop
branch
from
2b90b8c to
404996a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.