Timeouts #6
Merged
Timeouts #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the missing break statement, the address family was set to IPv4 though we have an aaaa record in the dns response.
Before this patch our thread was blocking as long as the server does not send a message. Now we can do additional stuff directly in this thread without waiting for the server.
At some points it does not make sense to send the QUIT signal before reconnecting.
This commit causes several changes to the internals of this library. We are now using the python builtin modules "sched" and "queue" to send and receive data. The connect function is now blocking until we reach the connect_timeout or the server sends the end of the motd. There are two new configuration variables: * connect_timeout * reconnect_interval
The previous behavior was an exception because self.outBuf is None in case of no connection.
With this patch the client is able to detect if the connection to the server is lost. So he is able to try to reconnect. There are two new configuration variables: * ping_timeout * ping_interval
Owner
|
I don't have any way to test the framework, but these changes are well explained and seem useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to implement some timeouts. The result is a better connect/reconnect behavior.
What do you think about it?
Implements #5