Fix bug where custom fields are not properly merged#199
Merged
Gummibeer merged 2 commits intofenos:masterfrom Aug 25, 2016
sudomabider:fix-merging-custom-fields-bug
Merged
Fix bug where custom fields are not properly merged#199Gummibeer merged 2 commits intofenos:masterfrom sudomabider:fix-merging-custom-fields-bug
Gummibeer merged 2 commits intofenos:masterfrom
sudomabider:fix-merging-custom-fields-bug
Conversation
added 2 commits
August 18, 2016 15:57
properly merge custom fields to Notification's fillable data
Collaborator
|
Hey, sorry for the long delay and thanks for your help! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experiencing 2 issues:
Notificatoinmodel,getCustomFillableFields()flattens the additional fields array from the config file which forces it to be a numeric array. And thenmergeFillable()uses array addition (+) which ignores the custom fields because the numeric keys already exist in the left-hand array.