Bump version to v0.8.3 and add dockerfile#2
Bump version to v0.8.3 and add dockerfile#2FrankYang0529 wants to merge 1 commit intofermyon:0.8from
Conversation
Signed-off-by: Frank Yang <yangpoan@gmail.com>
|
Hi @vdice, I would like to add the docker release pipeline for fermyon/bindle. May you help me review it? Thank you. |
|
Oh interesting approach :) I forgot we had a fork for the v0.8.0 backport(s). As of now, the workflows for this fork are disabled: Before enabling, we'd need to attend to a few other items in the release.yml workflow: there still are steps to publish to azure blob storage and crates.io, neither of which we're prepared to do from the fork (don't have sufficient creds, wouldn't want to overwrite). I guess we didn't envision actually creating a release from this fork :) I suppose one way forward would be to remove the blob storage/crates.io steps and then introduce the image push to this ghcr.io/fermyon/bindle repo. Alternatively, if we think this may be a one-off or seldom used (i.e. eventually we'd use the images that are now being pushed in deislabs/bindle when we/downstream consumers are ready to bump to v0.9.0+), maybe instead of enabling the workflow, we manually push a Let's check in with the team here - thoughts @endocrimes @dicej ? |
|
Yeah, I wouldn't spend a lot of time on CI/CD for this fork, since we're planning to switch back to upstream eventually, and I doubt we'll be making many (if any) more changes here. Manually pushing an image seems reasonable to me. |
|
Yeah, if we want to switch backup to upstream eventually, manually pushing an image makes sense to me. @vdice, may you help me create a |
|
@FrankYang0529 okay, I wouldn't oppose adding the Dockerfile and make target to this branch, but we can wait to see if we'll need to build/push from this branch in the future. Thanks again for supplying the Dockerfile and helping with a solution here! |
|
Hi @vdice, I tried to run fermyon/installer#100 with |
|
@FrankYang0529 Oh, sorry for the trouble here! I've rebuilt the image for |


ref: fermyon/installer#100 (comment)