docs(aws): updates per single-node/multi-node scenarios#116
docs(aws): updates per single-node/multi-node scenarios#116vdice merged 3 commits intofermyon:mainfrom
Conversation
vdice
requested review from
bacongobbler and
michelleN
and removed request for
michelleN
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
docs/aws-reorg
branch
from
c0ba2c9 to
d6363ad
Compare
michelleN
left a comment
michelleN
left a comment
There was a problem hiding this comment.
I need to look into where / how spin uses Hippo username and password.
|
|
||
| That being said, it should give users a quick look and feel for deploying apps | ||
| using Fermyon. By default, all apps will be accessible to the broader internet | ||
| (see the configuration details mentioned below). Additionally, when Let's Encrypt |
There was a problem hiding this comment.
Would add (LE) after Let's Encrypt since we're using the abbreviation later for folks who aren't familiar.
There was a problem hiding this comment.
I've updated the text here to just remove the LE mention...
| # Security disclaimer | ||
|
|
||
| By default for both scenarios, the allowed inbound and SSH CIDR block is | ||
| `0.0.0.0/0` aka The Entire Internet. |
aws/README.md
Outdated
| ssh -i /tmp/ec2_ssh_private_key.pem ubuntu@$(terraform output -raw eip_public_ip_address) | ||
| ``` | ||
|
|
||
| Once on the instance, output from user-data.sh can be checked like so: |
There was a problem hiding this comment.
Thank you, I've added a clarification here.
| export CONSUL_HTTP_ADDR=http://10.0.0.12:8500 | ||
| export NOMAD_ADDR=http://127.0.0.1:4646 | ||
| export BINDLE_URL=https://bindle.52.44.146.193.sslip.io/v1 | ||
| export HIPPO_URL=https://hippo.52.44.146.193.sslip.io |
There was a problem hiding this comment.
Is this supposed to be FERMYON_DEPLOYMENT_ENVIRONMENT or is it still HIPPO_URL?
There was a problem hiding this comment.
I'm unsure if this area can be updated/improved with a different approach introduced in recent Spin releases -- but for the purposes of spin login, I believe HIPPO_URL is still needed.
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
|
@michelleN I believe I've addressed all comments -- let me know if there are any others to look at. Thank you! |
|
|
||
| # How to Deploy | ||
|
|
||
| First, navigate to the `terraform` directory and initialize Terraform: |
There was a problem hiding this comment.
Is this section still accurate? I don't see a terraform dir in this dir and the terrform dir two levels up contains two other dirs not a terraform script.
There was a problem hiding this comment.
I think this should be terraform/multiple-nodes?
There was a problem hiding this comment.
Good catch! Both scenario READMEs should now be updated.
|
|
||
| # How to Deploy | ||
|
|
||
| First, navigate to the `terraform` directory and initialize Terraform: |
There was a problem hiding this comment.
I think this should be terraform/multiple-nodes?
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
2 participants
Some AWS-related docs updates/re-org following #100 cc @FrankYang0529