Conversation
Signed-off-by: jldeen <jessicadeen@me.com>
Signed-off-by: jldeen <jessicadeen@me.com>
Co-authored-by: Steven Murawski <steven.murawski@microsoft.com> Signed-off-by: jldeen <jessicadeen@me.com>
Signed-off-by: jldeen <jessicadeen@me.com>
Signed-off-by: jldeen <jessicadeen@me.com>
Signed-off-by: jldeen <jessicadeen@me.com>
Signed-off-by: Paul Yu <paul.d.yu@gmail.com>
vdice
left a comment
vdice
left a comment
There was a problem hiding this comment.
Apologies for the delayed review -- code LGTM! Thanks so much for adding Azure support.
Looking to others who might have an Azure sub handy to test this installer and deploy an example Spin app (cc @bnookala perhaps? 😄 )
Depending on timing, it would be great to update this installer to use the shared resources (Dependency versions, Nomad jobs, config, scripts) forthcoming in #76. It doesn't seem like there were any Azure-specific changes to these resources, but I'm not sure. In any case, this can definitely be a follow-up (especially if #76 is still in flight, of course). More of a 'heads up' here.
|
Now it's my turn to apologize for the delay. In addition to the minor updates I pushed, I also made a Fermyon Azure Quickstart to match the Fermyon AWS Quickstart. The video is currently unlisted on my channel, but happy to upload to a location of choice for the Fermyon channel. |
Signed-off-by: jldeen <jessicadeen@me.com>
Co-authored-by: Vaughn Dice <vaughn.dice@fermyon.com> Signed-off-by: Jessica Deen <jessicadeen@me.com> Signed-off-by: jldeen <jessicadeen@me.com>
vdice
left a comment
vdice
left a comment
There was a problem hiding this comment.
Thanks @jldeen! The Azure Quick Start video is so great 🙌
I'd definitely encourage linking the video in these docs, either/both in the azure/README.md added in this PR and/or in a dedicated Azure Quick Start doc that can live on the https://www.fermyon.dev site (see #89 for a mention of the latter).
It would be great to rev spin to the most recent release, but this can be a follow-up if preferred, especially if we wish to update this installer to use some of the shared dependency resources added recently.
LGTM -- but will wait to hear back around adding the video link and/or other updates we'd like to get in prior to merging....
…eadme Signed-off-by: jldeen <jessicadeen@me.com>
|
Thank you @vdice! Bumped spin and added the video to the readme. I will also make the video fully public (was unlisted before pending Fermyon's approval). Happy to also contribute to a dedicated Azure Quick Start doc for the https://www.fermyon.dev/ site! |
|
Excellent, thanks again @jldeen! |
4 participants
Adds support for Azure via Terraform
Closes Issue #62