Skip to content

Fix animation renaming #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fernandotonon merged 2 commits into from
Jun 2, 2023
Merged

Fix animation renaming #32

fernandotonon merged 2 commits into from
Jun 2, 2023

Conversation

@fernandotonon
Copy link
Owner

@fernandotonon fernandotonon commented Jun 2, 2023 •
edited
Loading

Summary

When renaming, the animations were getting weird animation results.
Also, it had some issues regarding disk access

image

Result:

Screen.Recording.2023-06-02.at.11.09.45.mov

Technical Details

  • The animations were getting renamed by exporting the skeleton as xml, replacing the name and reimporting the xml.
  • Now it clones the animation and apply to the skeleton in the memory

✨ Features

  • none

🐛 Bugfixes

  • Fixes renaming animation

@fernandotonon fernandotonon added the bug Something isn't working label Jun 2, 2023
@fernandotonon fernandotonon linked an issue Jun 2, 2023 that may be closed by this pull request
When renaming the animations get weird. #30
Closed
@fernandotonon fernandotonon merged commit efc158c into master Jun 2, 2023
@fernandotonon fernandotonon deleted the macos branch June 2, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

When renaming the animations get weird.

2 participants

@fernandotonon