feat: testnet support#349
Merged
Jonathansumner merged 3 commits intofeat/aasi-merger-cmdfrom May 16, 2024
Merged
Conversation
pbukva
reviewed
May 15, 2024
cmd/fetchd/cmd/genasiupgrade.go
Outdated
| ) | ||
|
|
||
| var networkInfos = map[string]NetworkConfig{ | ||
| "mainnet": { |
Collaborator
There was a problem hiding this comment.
As you suggested during the discussion, the key (the "mainnet" in this particular example) should have value of original chain-id from input genesis.json (e.g. fetchhub-4 in this particular case).
pbukva
reviewed
May 15, 2024
cmd/fetchd/cmd/genasiupgrade.go
Outdated
Comment on lines
+71
to
+74
| TokenBridge: TokenBridge{ | ||
| Addr: "fetch1qxxlalvsdjd07p07y3rc5fu6ll8k4tmetpha8n", // TODO(JS): amend this | ||
| NewAdmin: "fetch15p3rl5aavw9rtu86tna5lgxfkz67zzr6ed4yhw", // TODO(JS): amend this | ||
| }, |
Collaborator
There was a problem hiding this comment.
For testnet, there is no bridge contract = the function handling bridge contract should not be executed. Thei saso means that TokenBridge member in the structure should be pointer so it is not necessary to be set.
pbukva
reviewed
May 15, 2024
cmd/fetchd/cmd/genasiupgrade.go
Outdated
| func ASIGenesisUpgradeCmd(defaultNodeHome string) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "asi-genesis-upgrade", | ||
| Use: "asi-genesis-upgrade [testnet|mainnet]", |
Collaborator
There was a problem hiding this comment.
You can drop the [testnet|mainnet] paremeter (the decission wil be made automatically based on the chain-id value in the input genesis.json file.
pbukva
reviewed
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.