Fix progress parsing with audio (fix #400) #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Looks good to me, but maybe we can add this fix to here as well: https://github.com/ffmpegwasm/ffmpeg.wasm/blob/master/src/utils/parseProgress.js#L33 |
Collaborator
|
Let me add it after merging this PR, thanks for the PR! |
Collaborator
|
Just realized parseProgress is not in use anymore, will remove it instead. |
jeromewu
added a commit
that referenced
this pull request
Aug 10, 2023
Fix progress parsing with audio (fix #400)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was trying to find the current frame number even though it wasnt there, leading to an error.
Now it properly uses frames for progress when the input had video, and reverts properly to duration progress when only audio is present.