Add simple merge command #90 #102
Conversation
tests/test_merge.py
Outdated
| parquet = import_optional_dependency( | ||
| "pyarrow.parquet", extra="pyarrow is required for Parquet support." | ||
| ) |
There was a problem hiding this comment.
Is that an actual issue? We use it in other places, too, so it's not really optional, isn't it?
There was a problem hiding this comment.
I searched in the code on how to open/read/write parquet files (for testing this case). This is what I found in geopandas.py and I bluntly assumed this is how I should import it... Feel free to change
There was a problem hiding this comment.
Tested, it works
One thing we will run in to is the projection, especially with EPSG:4326 (WGS84) as default. Geometries can be transformed with a bijective function from source to target projection, but projected geometries can yield different validity results (e.g. intersecting lines). We will solve that as we encounter that.
|
Is there a better default? => #105 |
Implements #90