Skip to content

Conversation

@ivorbosloper
Copy link
Collaborator

Test if this works

@ivorbosloper
Copy link
Collaborator Author

Follow up of #133 (comment)

@m-mohr I just had to try it . It works. Not sure how well we like the changelog-requirement for 20-lines diff in the future

@m-mohr
Copy link
Contributor

m-mohr commented Dec 10, 2024

I mean it's not really a requirement, and for cases where it shouldn't apply I can bypass it :-)

@m-mohr
Copy link
Contributor

m-mohr commented Dec 10, 2024

I'd even say, if you could restrict it to only check the fiboa_cli folder (i.e. ignore, tests, docs, CI, etc) we could even "require" it for 1+ changed lines or so.

@ivorbosloper
Copy link
Collaborator Author

I'd even say, if you could restrict it to only check the fiboa_cli folder (i.e. ignore, tests, docs, CI, etc) we could even "require" it for 1+ changed lines or so.

I've changed the check for the fiboa_cli dir. The 20 is already a bit inflated as the diff-format adds like 5 lines for every changed file. We could test how well we like this action, if it's annoying we can disable it again.

@m-mohr m-mohr merged commit bc0faab into main Dec 10, 2024
3 checks passed
@m-mohr m-mohr deleted the changelog_action branch December 10, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants