Update datasets #191
Open
Update datasets #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ivorbosloper
commented
Oct 25, 2025
ivorbosloper
commented
- Support HCAT mapping CSV files without crop_code
- Split Germany BB and NDS in block dataset and crop fields
- Add HCAT to datasets where possible
- Updated years & variants for at_crop, be_vlg, es_an, es_cl, es_pv, ie, pt, se
- Rename at -> at_block and at_crop -> at, same for nl
Collaborator
Author
|
Tests await release of vecorel/cli#13 |
m-mohr
reviewed
Nov 28, 2025
Collaborator
Author
|
I'm awaiting a new release for vecorel I guess... The tests will work then... @m-mohr |
m-mohr
reviewed
Feb 11, 2026
Comment on lines
+41
to
+47
| # "mines_status": "mines_status", | ||
| # "mines_year_removed": "mines_year_removed", | ||
| "water_protect_zone": "water_protect_zone", | ||
| "natura2000": "natura2000", | ||
| "natura2000_ok": "natura2000_ok", | ||
| "natura2000_pop": "natura2000_pop", | ||
| "natura2000_povs": "natura2000_povs", | ||
| # "natura2000_ok": "natura2000_ok", | ||
| # "natura2000_pop": "natura2000_pop", | ||
| # "natura2000_povs": "natura2000_povs", |
Contributor
There was a problem hiding this comment.
Wny reason why they are skipped? Would probably be handy to have a comment in code why they are skipped for future reference
m-mohr
reviewed
Feb 11, 2026
| ec_mapping_csv = "hr_2020.csv" | ||
|
|
||
| def migrate(self, gdf) -> gpd.GeoDataFrame: | ||
| gdf["land_use_id"] = gdf["land_use_id"].astype(int) |
Contributor
There was a problem hiding this comment.
Isn't that a column migration?
m-mohr
reviewed
Feb 11, 2026
| "geometry": "geometry", | ||
| "CSBID": "id", | ||
| "CDL2023": "crop:code", | ||
| # "CDL2023": "crop:code", |
Contributor
There was a problem hiding this comment.
Here as well, we should document why we skip it or remove it completely from the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.