fix(fizarrita): bundle codec-worker for Vite production builds#4
Merged
fix(fizarrita): bundle codec-worker for Vite production builds#4
Conversation
Vite only recognises the combined `new Worker(new URL(..., import.meta.url))` pattern as a worker entry point. The previous approach stored the URL in a variable (`DEFAULT_WORKER_URL`) and passed it to `new Worker()` separately, causing Vite to copy codec-worker.js as a plain static asset without bundling its `./internals/*` dependencies. In production builds this left the worker's relative imports unresolved, crashing at runtime. Add `createDefaultWorker()` factory functions in get-worker.ts and set-worker.ts that use the combined expression. Deprecate `DEFAULT_WORKER_URL` (kept for backward compatibility) and export `createDefaultWorker` from the package. Bump version to 1.4.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite only recognises the combined
new Worker(new URL(..., import.meta.url))pattern as a worker entry point. The previous approach stored the URL in a
variable (
DEFAULT_WORKER_URL) and passed it tonew Worker()separately,causing Vite to copy codec-worker.js as a plain static asset without bundling
its
./internals/*dependencies. In production builds this left the worker'srelative imports unresolved, crashing at runtime.
Add
createDefaultWorker()factory functions in get-worker.ts and set-worker.tsthat use the combined expression. Deprecate
DEFAULT_WORKER_URL(kept forbackward compatibility) and export
createDefaultWorkerfrom the package.Bump version to 1.4.0.