Skip to content

new rule: no-duplicate-spread-property #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajafff merged 10 commits into from
Apr 26, 2018
Merged

new rule: no-duplicate-spread-property #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c378684
add some test cases
ajafff Apr 12, 2018
613a69b
make it work with unions and well known symbols
ajafff Apr 12, 2018
f2ed567
add baselines for older typescript versions
ajafff Apr 12, 2018
88a26a8
Add docs
ajafff Apr 12, 2018
198ae23
some cleanup and fixup
ajafff Apr 12, 2018
91df02a
require strictNullChecks
ajafff Apr 12, 2018
65af5a5
add test for destructuring
ajafff Apr 12, 2018
41a07b4
Merge branch 'master' into no-useless-object-property
ajafff Apr 26, 2018
6821e40
rename all the things
ajafff Apr 26, 2018
c5a9108
add tests with class methods
ajafff Apr 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
119 changes: 119 additions & 0 deletions baselines/packages/mimir/test/no-duplicate-spread-property/default/test.ts.lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
export {};

declare function get<T>(): T;

declare class WithMethods {
foo(): void;
bar: () => void;
baz: string;
}

const foo = 'foo';

({
x: 1,
~~~~ [error no-duplicate-spread-property: Property is overridden later.]
...{x: 2, y: 2},
~~~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
y: 1,
...{x: 3},
});

({
foo,
~~~ [error no-duplicate-spread-property: Property is overridden later.]
...{foo},
});

({
[foo]: 1,
~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
...{[foo]: 2},
});

({
'__@iterator': 1,
[Symbol.iterator]: 1,
~~~~~~~~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
...{[Symbol.iterator]: 2},
});

({
[get<string>()]: 1,
...{[get<string>()]: 2},
});

({
[get<'foo'>()]: 1,
...{[get<'foo'>()]: 2},
~~~~~~~~~~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
...{[foo]: 3},
});

({
foo: 1,
bar: 1,
~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
baz: 1,
~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
...get<{foo?: string, bar: number, baz: boolean | undefined}>(),
});

({
foo: 1,
bar: 1,
~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
baz: 1,
bas: 1,
...get<{foo: string, bar: number, bas: number} | {bar: number, baz: boolean, bas?: number}>(),
...Boolean() && {foo},
});

{
let a, b;
({[foo]: a, foo: b, ...{}} = get<{foo: string}>());
}

({
foo: 1,
bar: 1,
~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
baz: 1,
~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
...get<WithMethods>(),
});

({
foo() {},
bar: () => {},
~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
baz: get<() => void>(),
~~~~~~~~~~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
...get<WithMethods>(),
});

({
foo() {},
~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
bar: () => {},
~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
baz: get<() => void>(),
~~~~~~~~~~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
...get<{foo(): void, bar: () => void, baz: number}>(),
});

({
...get<WithMethods>(),
~~~~~~~~~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
foo() {},
bar: () => {},
baz: get<() => void>(),
});

({
...get<{foo: number, bar: number, baz: number}>(),
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [error no-duplicate-spread-property: Property is overridden later.]
foo() {},
bar: () => {},
baz: get<() => void>(),
});
101 changes: 101 additions & 0 deletions baselines/packages/mimir/test/no-duplicate-spread-property/loose/test.ts.lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
export {};

declare function get<T>(): T;

declare class WithMethods {
foo(): void;
bar: () => void;
baz: string;
}

const foo = 'foo';

({
x: 1,
...{x: 2, y: 2},
y: 1,
...{x: 3},
});

({
foo,
...{foo},
});

({
[foo]: 1,
...{[foo]: 2},
});

({
'__@iterator': 1,
[Symbol.iterator]: 1,
...{[Symbol.iterator]: 2},
});

({
[get<string>()]: 1,
...{[get<string>()]: 2},
});

({
[get<'foo'>()]: 1,
...{[get<'foo'>()]: 2},
...{[foo]: 3},
});

({
foo: 1,
bar: 1,
baz: 1,
...get<{foo?: string, bar: number, baz: boolean | undefined}>(),
});

({
foo: 1,
bar: 1,
baz: 1,
bas: 1,
...get<{foo: string, bar: number, bas: number} | {bar: number, baz: boolean, bas?: number}>(),
...Boolean() && {foo},
});

{
let a, b;
({[foo]: a, foo: b, ...{}} = get<{foo: string}>());
}

({
foo: 1,
bar: 1,
baz: 1,
...get<WithMethods>(),
});

({
foo() {},
bar: () => {},
baz: get<() => void>(),
...get<WithMethods>(),
});

({
foo() {},
bar: () => {},
baz: get<() => void>(),
...get<{foo(): void, bar: () => void, baz: number}>(),
});

({
...get<WithMethods>(),
foo() {},
bar: () => {},
baz: get<() => void>(),
});

({
...get<{foo: number, bar: number, baz: number}>(),
foo() {},
bar: () => {},
baz: get<() => void>(),
});
101 changes: 101 additions & 0 deletions baselines/packages/mimir/test/no-duplicate-spread-property/pre260/test.ts.lint
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
export {};

declare function get<T>(): T;

declare class WithMethods {
foo(): void;
bar: () => void;
baz: string;
}

const foo = 'foo';

({
x: 1,
...{x: 2, y: 2},
y: 1,
...{x: 3},
});

({
foo,
...{foo},
});

({
[foo]: 1,
...{[foo]: 2},
});

({
'__@iterator': 1,
[Symbol.iterator]: 1,
...{[Symbol.iterator]: 2},
});

({
[get<string>()]: 1,
...{[get<string>()]: 2},
});

({
[get<'foo'>()]: 1,
...{[get<'foo'>()]: 2},
...{[foo]: 3},
});

({
foo: 1,
bar: 1,
baz: 1,
...get<{foo?: string, bar: number, baz: boolean | undefined}>(),
});

({
foo: 1,
bar: 1,
baz: 1,
bas: 1,
...get<{foo: string, bar: number, bas: number} | {bar: number, baz: boolean, bas?: number}>(),
...Boolean() && {foo},
});

{
let a, b;
({[foo]: a, foo: b, ...{}} = get<{foo: string}>());
}

({
foo: 1,
bar: 1,
baz: 1,
...get<WithMethods>(),
});

({
foo() {},
bar: () => {},
baz: get<() => void>(),
...get<WithMethods>(),
});

({
foo() {},
bar: () => {},
baz: get<() => void>(),
...get<{foo(): void, bar: () => void, baz: number}>(),
});

({
...get<WithMethods>(),
foo() {},
bar: () => {},
baz: get<() => void>(),
});

({
...get<{foo: number, bar: number, baz: number}>(),
foo() {},
bar: () => {},
baz: get<() => void>(),
});
Loading