Skip to content

fix proto to be backward compatible#6

Merged
findingrish merged 1 commit intofindingrish:grpc-query-extensionfrom
andrisnoko:grpc-query-extension
Jul 19, 2024
Merged

fix proto to be backward compatible#6
findingrish merged 1 commit intofindingrish:grpc-query-extensionfrom
andrisnoko:grpc-query-extension

Conversation

@andrisnoko
Copy link
Copy Markdown

@andrisnoko andrisnoko commented Jul 17, 2024

Fixes #XXXX.

Description

The order of QueryRequest fields changed from initial test extension being used. Made QueryType.SQL the default to not break the test extension being used.

Makes it backward compatible with the test extension

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@findingrish findingrish merged commit b33a52f into findingrish:grpc-query-extension Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants