v0.4.1: New versioning system with branch protection#13
Merged
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe release workflow was updated to trigger on closed pull requests targeting the main branch instead of push events. The version tag retrieval and bumping logic were consolidated into a single step, streamlining tag determination from the PR title or latest git tag. All subsequent steps now reference the unified tag output. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant Git
Developer ->> GitHub Actions: Close PR to main
GitHub Actions ->> Git: Get PR title / latest tag
Git-->>GitHub Actions: Return tag or incremented version
GitHub Actions ->> Git: Tag, push, create tarball, release
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions workflow for releases to improve its functionality and adapt it for use with pull requests. The key changes include switching the trigger from
pushtopull_requestevents, enhancing tag handling, and simplifying version bump logic.Workflow Trigger Changes:
.github/workflows/release.yaml: Changed the workflow trigger to respond topull_requestevents of typeclosedinstead ofpushevents. This ensures the workflow runs when a pull request is merged.Tag and Version Handling Updates:
.github/workflows/release.yaml: Enhanced the logic to extract the version tag from the pull request title if available, falling back to the latest Git tag otherwise. This simplifies version management during releases..github/workflows/release.yaml: Updated all references to usesteps.get_tag.outputs.new_taginstead ofsteps.bump.outputs.new_tagfor consistency and clarity in tag handling.Release Asset and Dispatch Adjustments:
.github/workflows/release.yaml: Modified the tarball creation and GitHub release steps to use the new tag output, ensuring accurate versioning in release assets..github/workflows/release.yaml: Adjusted the repository dispatch payload to reference the updated tag output for the tarball URL and version.Summary by CodeRabbit