Skip to content

Linux support menu#20

Merged
finityfly merged 1 commit intomainfrom
feat/linux-sup
Sep 17, 2025
Merged

Linux support menu#20
finityfly merged 1 commit intomainfrom
feat/linux-sup

Conversation

@finityfly
Copy link
Owner

@finityfly finityfly commented Sep 17, 2025

This pull request introduces a platform-specific improvement to the user interface instructions in the Menu::display method. The code now displays navigation instructions tailored to Linux systems, enhancing clarity for users depending on their operating system.

User interface improvements:

  • src/Menu.cpp: Added conditional logic to display navigation instructions as [^/v]: navigate - [ENTER]: select for Linux systems, and [↑/↓]: navigate - [ENTER]: select for other platforms.

Summary by CodeRabbit

  • Bug Fixes
    • On Linux, the bottom navigation hint now uses ASCII indicators ("[^/v]: navigate - [ENTER]: select").
    • On non-Linux platforms, the hint continues to show Unicode arrows ("[↑/↓]: navigate - [ENTER]: select").
    • Applies only to the instruction line at the bottom of the menu display.
    • No other UI elements or interactions are affected.

@coderabbitai
Copy link

coderabbitai bot commented Sep 17, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds OS-conditional rendering for the bottom instruction text in Menu::display: Linux builds show ASCII "[^/v]: navigate - [ENTER]: select"; non-Linux builds keep Unicode "[↑/↓]: navigate - [ENTER]: select". No other logic or layout changes.

Changes

Cohort / File(s) Summary
Menu instruction rendering
src/Menu.cpp
Introduced #ifdef __linux__ to switch bottom instruction text between ASCII ([^/v]) on Linux and Unicode ([↑/↓]) elsewhere; no changes to input handling or layout.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my ears at arrows bright,
ASCII on Linux, Unicode in flight—
A hop between builds, neat and slight,
Bottom hints aligned just right.
Carrots, keys, and menus tight—
Press ENTER, choose delight! 🥕⬆️⬇️

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/linux-sup

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4741e89 and 50b2608.

📒 Files selected for processing (1)
  • src/Menu.cpp (1 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@finityfly finityfly merged commit 154d7ea into main Sep 17, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant