Skip to content

Conversation

@thorsent
Copy link

The former timeout period of 1 second was not enough to guarantee that test windows were closed before the next test began (e.g. when running conformance tests in CI on slow VDIs).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 24, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link
Contributor

@kriswest kriswest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thorsent 👋

Seems fine to me.

Note this code also exists at https://github.com/finos/FDC3/blob/main/toolbox/fdc3-conformance/src/constants.ts

However, it looks like some past work on this framework was not merged back into it and @robmoffat has continued the development from an uncertain point (or perhaps with an uncertain number of past fixes that should have been merged back to main?) for the 2.2 changes:
image

I'm not sure what is being done to sort that out currently... Once done this project should be archived.

For now I would suggest also making this change at: https://github.com/finos/FDC3/blob/main/toolbox/fdc3-conformance/src/constants.ts

@thorsent
Copy link
Author

Thanks @kriswest , I wasn't aware the conformance tests had been consolidated into the fdc3 repo. I've pushed a PR with a corresponding change.

@robmoffat
Copy link
Member

I've raised #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants