-
Notifications
You must be signed in to change notification settings - Fork 154
Description
Is your feature request related to a problem? Please describe.
Currently, the parsePush action only allows pushing branches.
The recent TS refactors make it throw an Invalid commit data error instead, but without successfully pushing and allowing a review.
Describe the solution you'd like
Add support for pushing tags (ref/tags/) and potentially other things such as notes (ref/notes/). This could be done through a plugin or by extending parsePush to handle more kinds of pushes.
Adding tag push support would require deeper changes to how commitData is parsed and used in subsequent actions to check their content. We should also think about the edge case of pushing only a tag without the branch ("hidden" commit data must be validated).
Allowing annotated tags would be great too:
git tag --annotate foo -m ''
git cat-file tag foo
git push --tagsDescribe alternatives you've considered
Perhaps this could be done through a plugin instead? Modifying the push action seems to be the easiest solution.
Additional context
None