chore: add testing documentation and coverage checks#1147
chore: add testing documentation and coverage checks#1147jescalada merged 29 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 82.86% 83.22% +0.35%
==========================================
Files 66 66
Lines 2795 2795
Branches 332 332
==========================================
+ Hits 2316 2326 +10
+ Misses 431 423 -8
+ Partials 48 46 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
dcoric
left a comment
There was a problem hiding this comment.
Very good in general, I just added a small nitpick.
kriswest
left a comment
There was a problem hiding this comment.
Lots of good stuff here! I'd like to see resetting stubs emphasized as I lost a couple of hours to debugging confusing issues caused by stubs that were not reset.
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
|
Might be worth updating the template test and including sinon/proxyquire examples in it: https://github.com/finos/git-proxy/blob/main/test/1.test.js |
|
@kriswest Should be ready for a final look! |
Implements the coverage checks mentioned in #1019, although it doesn't add any auto-merge on coverage attained (we still want maintainers to take a look at larger PRs and decide the right time to merge).
I've also added some documentation on how to implement unit, E2E and fuzz tests for new PRs.