fix: allowing empty diffs in scanDiff#1182
Merged
kriswest merged 14 commits intofinos:mainfrom Sep 10, 2025
Merged
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1182 +/- ##
==========================================
+ Coverage 83.67% 83.71% +0.03%
==========================================
Files 67 67
Lines 2886 2886
Branches 365 365
==========================================
+ Hits 2415 2416 +1
Misses 410 410
+ Partials 61 60 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kriswest
reviewed
Sep 8, 2025
Contributor
kriswest
left a comment
There was a problem hiding this comment.
Little confused about the test expecting two different possible outputs (block and non-block).
Test files could be moved into the /test/processors folder.
…-proxy into pr/fabiovincenzi/1182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1008 - scanDiff now properly handles force pushes after rebases by allowing legitimate empty diffs instead of blocking them.