refactor: remove any and as throughout codebase#1323
refactor: remove any and as throughout codebase#1323jescalada wants to merge 64 commits intofinos:mainfrom
any and as throughout codebase#1323Conversation
…ttestation definition
…elds, remove any in src/proxy/routes/index
Sets stub types to (`ReturnType<typeof vi.fn>`) to remove the any type
…for req and stubs
…/jescalada/git-proxy into 1174-remove-any-and-as-ts-wrapup
…y, jwtAuthHandler)
… for edge case tests
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… match original ones
…ry proxy variable
…or tab identifier
|
@kriswest Ready for a final look! |
|
@jescalada trying to fit in a final pass, but you've developed a whole load of conflicts unfortunately. |
kriswest
left a comment
kriswest
left a comment
There was a problem hiding this comment.
Mostly LGTM, one small issue. The very large diff includes changes from other PRs - that can be avoided by rebasing main rather than merging in future.
I think it best if this goes in ASAP as its getting way too long to review effectively.
One small error to fix + a minor refinement suggested.
Co-authored-by: Kris West <kristopher.west@natwest.com> Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
|
@kriswest Should be ready now! Coverage is 89.69%, which is much better than I imagined despite the extra code. Might be worth taking another pass at improving coverage down the line, but we're at a much better spot compared to March last year (62%). |
2 participants
Fixes #1174.