Skip to content

fix: file permission issue in e2e tests & regression on db init#1358

Merged
coopernetes merged 2 commits intomainfrom
fix/e2e-regression
Jan 20, 2026
Merged

fix: file permission issue in e2e tests & regression on db init#1358
coopernetes merged 2 commits intomainfrom
fix/e2e-regression

Conversation

@coopernetes
Copy link
Contributor

@coopernetes coopernetes commented Jan 20, 2026

Closes #1354

Two fixes to e2e tests as well as a regression caused by the app
initialization.

  • pullRemote - Error: EACCES: permission denied, mkdir './.remote' errors during e2e test runs (Dockerfile fix of file permissions)
  • Fix issue where getAllProxiedHosts() does not complete until after the Express router starts up, leading the git-server:8443 origin to not be proxied (regression from fix: defer reading of database configuration until needed to fix race #1316) which causes the proxy to default to github.com. The following logs are observed in the git-proxy container:
$ docker compose logs git-proxy
Created runtime configuration with:
  API URL: auto-detect
  Allowed Origins: *
  Environment: test
Configuration sources are disabled
Configuration loaded successfully
Setting config file to: /app/test-e2e.proxy.config.json
validating config
Setting up the proxy and Service
No plugins configured
Found 0 plugin modules
Loading MongoDB database adaptor
creating new repo {"project":"coopernetes","name":"test-repo","url":"https://git-server:8443/coopernetes/test-repo.git","users":{"canPush":[],"canAuthorise":[]}}
creating new repo {"project":"finos","name":"git-proxy","url":"https://git-server:8443/finos/git-proxy.git","users":{"canPush":[],"canAuthorise":[]}}
Initializing proxy router for origins: '[]'
        setting up catch-all route (github.com) for backwards compatibility
        
       # !!! Note how git-server:8443 is never added as a proxied origin ^
...
checkRepoInAuthorisedList - repo https://git-server:8443/coopernetes/test-repo.git is in the authorisedList
Action processed: Allowed
    Request URL: /git-server:8443/coopernetes/test-repo.git/info/refs?service=git-upload-pack
    Host:        localhost:8000
    User-Agent:  git/2.52.0
Request resolved to https://github.com/git-server:8443/coopernetes/test-repo.git/info/refs?service=git-upload-pack

       # !!! Request incorrectly proxied to github.com instead of git-server:8443 ^

@netlify
Copy link

netlify bot commented Jan 20, 2026

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 36781fd
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/696f0c1cf590ce0008906ac5

@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions bot added the fix label Jan 20, 2026
@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.40%. Comparing base (930a5da) to head (36781fd).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1358   +/-   ##
=======================================
  Coverage   80.40%   80.40%           
=======================================
  Files          65       65           
  Lines        4608     4608           
  Branches      776      775    -1     
=======================================
  Hits         3705     3705           
  Misses        888      888           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coopernetes
Copy link
Contributor Author

/test e2e

@coopernetes coopernetes enabled auto-merge January 20, 2026 05:04
@coopernetes coopernetes merged commit 718f961 into main Jan 20, 2026
24 checks passed
@coopernetes coopernetes deleted the fix/e2e-regression branch January 20, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix broken build — E2E tests failing due to missing local git repo

1 participant