feat: add TLS support to API/UI service#1414
Open
fabiovincenzi wants to merge 9 commits intofinos:mainfrom
Open
feat: add TLS support to API/UI service#1414fabiovincenzi wants to merge 9 commits intofinos:mainfrom
fabiovincenzi wants to merge 9 commits intofinos:mainfrom
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
+ Coverage 90.01% 90.09% +0.07%
==========================================
Files 67 67
Lines 4769 4816 +47
Branches 885 897 +12
==========================================
+ Hits 4293 4339 +46
Misses 458 458
- Partials 18 19 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jescalada
reviewed
Feb 25, 2026
| cert: | ||
| config.getTLSEnabled() && config.getTLSCertPemPath() | ||
| ? fs.readFileSync(config.getTLSCertPemPath()!) | ||
| : undefined, |
Contributor
There was a problem hiding this comment.
Is it okay to reuse the proxy TLS credentials for the service and UI or should these be separate configurable parameters 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1408
Add HTTPS on port 8444 (configurable via
GIT_PROXY_HTTPS_UI_PORT) to the API/UI service, using the existingtls.enabled/key/certconfig fields already used by the proxy. HTTP and HTTPS run in parallel.