test: increased test coverage for push action#805
test: increased test coverage for push action#805Sabarivasan-Velayutham wants to merge 2 commits intofinos:mainfrom
Conversation
|
✅ Deploy Preview for endearing-brigadeiros-63f9d0 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This looks like it was a solid contribution, I'm sorry it didn't get merged. I think that much of this work has now been superseded in the project, and we never got a signed CLA allowing us to merge it. Hence, I think it time to close this PR. However, if you know there are things in here that we don't yet have and would like help completing a CLA get in touch, either here or with help@finos.org. |
|
Hi @kriswest , I have already raised the EasyCLA authorization request several times but haven’t received an approval email yet. I have submitted it again now, and the approver shows as Rhyddian Olds. Could you help me please approve the EasyCLA request and reopen this branch for merge once it’s approved? Thanks! |
|
Note if the request has been approved you need to hit the 'click here to be authorised' link again to be rechecked, which isn't obvious. If it's not that you'll need help from Rhydian. |
|
Hi @kriswest , I didn't get any approval notification/mail for this till now. Even yesterday I have given approval request , but still didn't get any response. Please check on this. By the way, I don't have contact to reach Rhydian to ask on this. |
Issue : Increase test coverage to 80% ⚡️ #240
This pull request introduces test cases for the
push actionto improve the overall test coverage of the codebase. A small but impactful increase in test coverage has been achieved as part of this effort.Key Updates:
push actionin thetestfolder.push actionmodule.nycto analyze the current test score and identify areas for improvement.Changes Made
push action.nyccoverage reports.Evidence
Below is the screenshot of the test coverage report for push action :
Checklist
nyc.