fix: neDB implementation issues#979
Conversation
…file-based DB implementation
…file-based DB implementation
…file-based DB implementation
…file-based DB implementation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #979 +/- ##
==========================================
+ Coverage 53.80% 60.15% +6.35%
==========================================
Files 53 53
Lines 2171 2196 +25
Branches 244 250 +6
==========================================
+ Hits 1168 1321 +153
+ Misses 952 840 -112
+ Partials 51 35 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR has one more push to come that will hopefully complete the code coverage. Should be reviewed and pushed tomorrow |
|
One last commit to push on this PR that should get coverage on /src/db/file up to near 100% - might get pushed after easter now. |
|
@JamieSlome @coopernetes @grovesy this PR should be ready to go now |
JamieSlome
left a comment
There was a problem hiding this comment.
@kriswest - before I review pre-merge, can we confirm that the linting changes are aligned with the current config and expectation asserted by the project?
|
@JamieSlome I was set-up as per the project config, however the project config doesn't cover packages/git-proxy-cli! I've tweaked the format command so that it does apply and run it. I tried to add prettier to the child project directly but it's not working there, so I extended the parent project's format command to cover it instead. This adds a bunch of files to the PR with minor changes - waiting on a review then will push |
|
@JamieSlome prettier was run on everything and should be applying to packages/git-proxy-cli. It looks like that was previously formatted with different settings / narrower width. Does it look right to you? |
…into 948-neDB-implementation-issues
coopernetes
left a comment
There was a problem hiding this comment.
These are all welcome changes and LGTM on the database side. I'm leaving the UI review to @JamieSlome
|
Conflict resolutions on their way... |
|
Conflicts resolved |
sam-holmes2
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution :)
resolves #948
resolves #947
Fixes a number of shortcomings in the file DB implementation, including:
Changes were also applied to the mongo DB classes:
addUserCanPushandaddUserCanAuthorise, its just not being applied consistentlyFinally, tests were updates: