Skip to content

refactor(tsx): Migrate React components to TSX#984

Merged
jescalada merged 53 commits intofinos:mainfrom
fabiovincenzi:react-conversion
Jul 10, 2025
Merged

refactor(tsx): Migrate React components to TSX#984
jescalada merged 53 commits intofinos:mainfrom
fabiovincenzi:react-conversion

Conversation

@fabiovincenzi
Copy link
Contributor

Fixes #983.
This PR refactors all actively used React components and their styles from JavaScript/JSX to TypeScript/TSX, leaving any unused components untouched.

@netlify
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit d3235d7
🔍 Latest deploy log https://app.netlify.com/sites/endearing-brigadeiros-63f9d0/deploys/68021f6785aea80008e45244

@netlify
Copy link

netlify bot commented Apr 18, 2025

Deploy Preview for endearing-brigadeiros-63f9d0 canceled.

Name Link
🔨 Latest commit 0175d85
🔍 Latest deploy log https://app.netlify.com/projects/endearing-brigadeiros-63f9d0/deploys/686fc0c6d614da00082ecc93

@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.41%. Comparing base (f64c5e6) to head (0175d85).
Report is 54 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #984   +/-   ##
=======================================
  Coverage   77.41%   77.41%           
=======================================
  Files          55       55           
  Lines        2276     2276           
  Branches      255      255           
=======================================
  Hits         1762     1762           
  Misses        484      484           
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fabiovincenzi fabiovincenzi linked an issue Apr 24, 2025 that may be closed by this pull request
2 tasks
Copy link
Contributor

@jescalada jescalada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe to make things cleaner, we could extract the interfaces from each file into a types file instead.

@JamieSlome
Copy link
Member

@fabiovincenzi - can you resolve the merge conflicts then we'll get this merged? ❤️

@fabiovincenzi
Copy link
Contributor Author

All good now, also unified a few duplicated interfaces @JamieSlome

@fabiovincenzi
Copy link
Contributor Author

Is this something we can merge? @JamieSlome

@jescalada
Copy link
Contributor

@fabiovincenzi Is this ready to merge? 🤔

@fabiovincenzi
Copy link
Contributor Author

@jescalada Yes, I think this is ready. I just fixed a few type-checks.

@jescalada
Copy link
Contributor

Looks good to me! This will be very helpful for the MUI v5 migration. 🚀

@jescalada jescalada merged commit 15c68a3 into finos:main Jul 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert React components from JSX to TSX [Migration] Convert React Components to TS

3 participants