Skip to content

fix: Set the Quota Project ID only for ADC human accounts#2761

Merged
lahirumaramba merged 3 commits intomasterfrom
lm-fix-quotaproject
Nov 8, 2024
Merged

fix: Set the Quota Project ID only for ADC human accounts#2761
lahirumaramba merged 3 commits intomasterfrom
lm-fix-quotaproject

Conversation

@lahirumaramba
Copy link
Member

@lahirumaramba lahirumaramba commented Nov 5, 2024 •
edited
Loading

  • The quota project id should only be set for Application default credentials with human accounts.
  • The SDK will use the quota project id found in credentials (through google-auth-client).
  • GOOGLE_CLOUD_QUOTA_PROJECT overrides the project id found in credentials.

This PR fixes #2658

@lahirumaramba lahirumaramba added release-note release:stage Stage a release candidate labels Nov 5, 2024
@lahirumaramba lahirumaramba mentioned this pull request Nov 7, 2024
Merged
@lahirumaramba lahirumaramba force-pushed the lm-fix-quotaproject branch 2 times, most recently from 302d0d7 to 6c0657b Compare November 7, 2024 22:34
@lahirumaramba lahirumaramba changed the title fix: Set the Quota Project ID for ADC human accounts fix: Set the Quota Project ID only for ADC human accounts Nov 7, 2024
@lahirumaramba lahirumaramba force-pushed the lm-fix-quotaproject branch 2 times, most recently from f150b71 to d54a4da Compare November 7, 2024 22:54
@lahirumaramba lahirumaramba mentioned this pull request Nov 7, 2024
Closed
jonathanedey
jonathanedey approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@lahirumaramba lahirumaramba merged commit 4ee1bb2 into master Nov 8, 2024
@lahirumaramba lahirumaramba deleted the lm-fix-quotaproject branch November 8, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathanedey jonathanedey jonathanedey approved these changes

Assignees

@lahirumaramba lahirumaramba

Labels

release:stage Stage a release candidate release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrading firebase-admin requires additional serviceUsageConsumer permissions

2 participants

@lahirumaramba @jonathanedey