Using the new HttpClient API in Credentials #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bojeil-google
suggested changes
Jul 28, 2018
Contributor
bojeil-google
left a comment
bojeil-google
left a comment
There was a problem hiding this comment.
Looks good. Just some nits while you are already making these changes.
src/auth/credential.ts
Outdated
| */ | ||
| export class CertCredential implements Credential { | ||
| private certificate_: Certificate; | ||
| private readonly certificate_: Certificate; |
Contributor
There was a problem hiding this comment.
since you're already modifying this, let's remove the trailing underscore.
src/auth/credential.ts
Outdated
| */ | ||
| export class RefreshTokenCredential implements Credential { | ||
| private refreshToken_: RefreshToken; | ||
| private readonly refreshToken_: RefreshToken; |
Contributor
There was a problem hiding this comment.
Same here. Let's remove trailing underscore.
bojeil-google
approved these changes
Jul 30, 2018
This was referenced Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new
HttpClientAPI in Credentials module. With this I believe we are using the new API everywhere in the SDK (I will create a separate PR to remove the old code). I also managed to re-enable an old refresh token unit test that had been disabled for a long time.This is a follow up to #280, #291, and #301