Update support for type hints

[ViktorSky]

This pull request introduces comprehensive type annotations to the firebase_admin codebase using PEP 484 standards. All changes have been validated with Pyright in strict mode to enforce consistency and catch potential type errors early.

Goals

• Enhance developer experience with precise autocomplete and type hints.
• Catch type-related bugs upfront via static analysis.

Tools

• Pyright in strict mode for robust type-checking.
• Manual review of ambiguous or potentially problematic sections.
• The linter can also be run directly from the terminal using:

  pyright
  

Configuration Additions

• pyrightconfig.json: config file created to declare strict-mode settings.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @ViktorSky, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a foundational enhancement to the firebase_admin Python SDK by implementing comprehensive type annotations throughout its modules. The primary goal is to elevate code quality, improve developer experience by enabling more effective static analysis, and reduce the likelihood of type-related bugs. The integration of Pyright in strict mode ensures that these type annotations are rigorously enforced, contributing to a more reliable and predictable codebase.

Highlights

• Comprehensive Type Annotations: Extensive type hints have been added across nearly all Python files within the firebase_admin codebase, adhering to PEP 484 standards. This significantly improves code clarity and maintainability.
• Pyright Integration: The project now integrates Pyright as a strict-mode type checker, with a new pyrightconfig.json file defining the configuration. This ensures consistent type validation and early detection of type-related issues.
• Enhanced Developer Experience: The addition of type hints aims to provide developers with more precise autocompletion, better IDE support, and a more robust development workflow by catching type-related bugs during static analysis rather than at runtime.
• Dependency Updates: New development dependencies including pyright, typing-extensions, types-requests, and types-httplib2 have been added to requirements.txt and setup.py to support the new type-checking infrastructure.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This is an impressive and comprehensive effort to add type annotations across the firebase_admin codebase. The changes significantly improve the developer experience by enabling static analysis, leading to better code quality and maintainability. The use of modern typing features like TypeVar, Generic, Literal, and overload is excellent. The refactoring of create_user and update_user to use explicit keyword arguments instead of **kwargs is a particularly noteworthy improvement for API clarity and safety. I have one minor suggestion to make the HttpClient more robust after being closed.