Skip to content

Conversation

@Salakar
Copy link
Member

@Salakar Salakar commented May 8, 2020

Description

Fix for CI failures highlighted in #2499.

  • Added missing gradle.properties AndroidX properties to cloud_functions example repository
  • Updated environment SDK version range to fix Packages with an SDK constraint on a pre-release of the Dart SDK should themselves be published as a pre-release version. If this package needs Dart version 2.0.0-dev.28.0, consider publishing the package as a pre-release instead. CI publishable issue.

Before

image

image

After

image

image

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Salakar Salakar changed the title fix(examples): remove unnecessary junit dependency chore(android,ci): remove unnecessary junit dependency May 8, 2020
@Salakar Salakar changed the title chore(android,ci): remove unnecessary junit dependency chore(android,ci): fix ci failures May 8, 2020
@Salakar Salakar force-pushed the @salakar/ci-android-fix branch from 523226a to f243968 Compare May 8, 2020 16:36
@Salakar Salakar marked this pull request as ready for review May 8, 2020 17:09
@Salakar Salakar changed the title chore(android,ci): fix ci failures fix(cloud_functions): ci failures May 12, 2020
@helenaford helenaford assigned helenaford and unassigned helenaford May 12, 2020
@Salakar Salakar merged commit 7898e33 into master May 12, 2020
@Salakar Salakar deleted the @salakar/ci-android-fix branch May 12, 2020 12:22
@Salakar Salakar mentioned this pull request May 12, 2020
@cyanglaz
Copy link

Just saw this PR. We should probably increase the dark sdk lower bound instead of decreasing it. Any particular language feature we need in the plugin in 2.0.0?

@Salakar
Copy link
Member Author

Salakar commented May 12, 2020

Just saw this PR. We should probably increase the dark sdk lower bound instead of decreasing it. Any particular language feature we need in the plugin in 2.0.0?

Isn't changing 2.0.0-dev.28.0 to 2.0.0 increasing the lower bound SDK version already?

The change was just to remove it from referencing pre-release versions of the Dart SDK - changing to 2.0.0 was the initial safest bet I thought with the least upgrade/changes friction.

@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants