-
Notifications
You must be signed in to change notification settings - Fork 4.1k
fix(cloud_functions): ci failures #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
523226a to
f243968
Compare
|
Just saw this PR. We should probably increase the dark sdk lower bound instead of decreasing it. Any particular language feature we need in the plugin in 2.0.0? |
Isn't changing
The change was just to remove it from referencing pre-release versions of the Dart SDK - changing to |
Description
Fix for CI failures highlighted in #2499.
gradle.propertiesAndroidX properties tocloud_functionsexample repositoryPackages with an SDK constraint on a pre-release of the Dart SDK should themselves be published as a pre-release version. If this package needs Dart version 2.0.0-dev.28.0, consider publishing the package as a pre-release instead.CI publishable issue.Before
After
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?