fix(go/ai): genkit ignores dotprompt-defined roles#3780
fix(go/ai): genkit ignores dotprompt-defined roles#3780hugoaguirre merged 2 commits intofirebase:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
b19d47f to
ea17dd1
Compare
hugoaguirre
left a comment
There was a problem hiding this comment.
Thanks for your contribution! Overall, LGTM 👍🏽
|
@hugoaguirre @rutujaD1999 @apascal07 My actual verification did not solve this problem, and this submission introduced a new bug. The modified code has caused the shared variable to behave in such a way that when multiple threads access the same prompt simultaneously, the message remains unchanged indefinitely. |
|
@rutujaD1999 please take a look. |
Fixed Genkit's prompt load to respect role definitions from dotprompt files instead of forcing all messages to use the "user" role.
#3711
Checklist (if applicable):