Skip to content

fix(go/ai): fix race condition in concurrent prompt rendering #3837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugoaguirre merged 3 commits into from
Nov 26, 2025
Merged

fix(go/ai): fix race condition in concurrent prompt rendering #3837

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1afcb03
fix(ai): fix race condition in concurrent prompt rendering
eric642 Nov 21, 2025
5447853
Update go/ai/prompt.go
eric642 Nov 25, 2025
ba862bf
format code
eric642 Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions go/ai/prompt.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,8 @@ func renderMessages(ctx context.Context, opts promptOptions, messages []*Message
return nil, err
}

// Create new message copies to avoid mutating shared messages during concurrent execution
renderedMsgs := make([]*Message, 0, len(msgs))
for _, msg := range msgs {
msgParts := []*Part{}
for _, part := range msg.Content {
Expand All @@ -436,12 +438,21 @@ func renderMessages(ctx context.Context, opts promptOptions, messages []*Message
return nil, err
}
msgParts = append(msgParts, parts...)
} else {
// Preserve non-text parts as-is
msgParts = append(msgParts, part)
}
}
msg.Content = msgParts
// Create a new message with rendered content instead of mutating the original
renderedMsg := &Message{
Role: msg.Role,
Content: msgParts,
Metadata: msg.Metadata,
}
renderedMsgs = append(renderedMsgs, renderedMsg)
}

return append(messages, msgs...), nil
return append(messages, renderedMsgs...), nil
}

// renderPrompt renders a prompt template using dotprompt functionalities
Expand Down
Loading