Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/utils.ts">
<violation number="1" location="src/utils.ts:210">
P2: `matchedRule` is populated only from `rule.if`, so rules that match via `exists`/`changes` without `if` are not shown by `--list-rule`, making the output misleading for valid rules.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
In my use cases, we have complex pipeline configurations and having the ability to see what rule is being matched is helpful for debugging when jobs unexpectedly are or aren't being added to the pipeline.
Proposed Solution
This new flag would result in similar output to --list but would display the rule that a job matched on, i.e. the one that was triggered by rules conditions that result in it being added to the "list".
Changes
Summary by cubic
Adds a new
--list-ruleflag to list jobs and show which rule condition(s) matched (if/exists/changes), replacing the needs column in this mode. Works with--evaluate-rule-changesto surface matchedchangespatterns.New Features
--list-rule(+ help text) that switches list view to a “rule” column.Utils.getRulesResultintoJob.matchedRule; rules with onlywhendo not print.Bug Fixes
rules.test.tsto assertmatchedRuleoutputs; fixed ESLint and yamllint issues.Written for commit 93766de. Summary will update on new commits.