finat_element.is_lagrange #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
reviewed
Dec 5, 2025
| '''Appropriate mapping from the reference cell to a physical cell for | ||
| all basis functions of the finite element.''' | ||
|
|
||
| def is_lagrange(self): |
There was a problem hiding this comment.
- Is
is_lagrangea good name? Maybehas_only_point_evaluation_dofs? (or something in between) - Should this be a
cached_property?
There was a problem hiding this comment.
KMV and Crouzeix-Raviart have only point wise evaluation dofs but aren't "Lagrange". If we want this function to return True on those, we should change the name. Connor's proposed name is verbose, but I can't think of a shorter one.
a cached_property seems reasonable, but would we break consistency with other such queries internally?
There was a problem hiding this comment.
It is more pythonic to use properties for this sort of thing. For example UFL is trying to move away from argument-less methods (like the recent .topological_dimension() to .topological_dimension.
pbrubeck
commented
Dec 5, 2025
pbrubeck
force-pushed
the
pbrubeck/is-lagrange
branch
from
c44a163 to
4072e63
Compare
pbrubeck
commented
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.