Skip to content

Conversation

@Ig-dolci
Copy link
Contributor


name: "Bug fix or new feature"
description: ''
title: ''
labels: ''
assignees: ''


Description

Please include a summary of the changes introduced by this PR.
Additionally include any relevant motivation and context. List any
dependencies that are required for this change, other PRs upon
which this may depend, and associated issues.

Associated Pull Requests:

Fixes Issues:

If issues are fixed by this PR, prepend each of them with the word
"fixes", so they are automatically closed when this PR is merged. For
example "fixes #123, fixes #456".

Checklist for author:

  • I have linted the codebase (make lint in the firedrake source directory).
  • My changes generate no new warnings.
  • All of my functions and classes have appropriate docstrings.
  • I have commented my code where its purpose may be unclear.
  • I have included and updated any relevant documentation.
  • Documentation builds locally (make linkcheck; make html; make latexpdf in firedrake/docs directory)
  • I have added tests specific to the issues fixed in this PR.
  • I have added tests that exercise the new functionality I have introduced
  • Tests pass locally (pytest tests in the firedrake source directory) (useful, but not essential if you don't have suitable hardware).
  • I have performed a self-review of my own code using the below guidelines.

Checklist for reviewer:

  • Docstrings present
  • New tests present
  • Code correctly commented
  • No bad "code smells"
  • No issues in parallel
  • No CI issues (excessive parallelism/memory usage/time/warnings generated)
  • Upstream/dependent branches and PRs are ready

Feel free to add reviewers if you know there is someone who is already aware of this work.

Please open this PR initially as a draft and mark as ready for review once CI tests are passing.

@Ig-dolci Ig-dolci marked this pull request as ready for review October 13, 2023 13:50
@Ig-dolci
Copy link
Contributor Author

Reviewing the instructions for firedrake installation on Mac is also necessary.

@Ig-dolci Ig-dolci requested review from connorjward and dham October 13, 2023 13:53
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we update the website I think it would be good for someone else to follow the steps and make sure it solves the issue for them.

Comment on lines 113 to 115
MacOS, due to current issues with Xcode 15 and MPI_, we recommend to follow the
instructions available
`here < https://github.com/firedrakeproject/firedrake/wiki/Installation-instructions-for-macOS>`_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this should be put in a text box

.. note::
  Due to current issues with Xcode 15...

@JDBetteridge
Copy link
Member

I have found additional issues with the installer that prevent the documented changes from working properly.
Essentially setting LDFLAGS in PETSC_CONFIGURE_OPTIONS may or may not (due to the unordered nature of Python set()) take precedence the LDFLAGS used to control BLAS linking in PETSc.

This requires a bigger fix, although probably needs discussion.

@Ig-dolci
Copy link
Contributor Author

I have found additional issues with the installer that prevent the documented changes from working properly. Essentially setting LDFLAGS in PETSC_CONFIGURE_OPTIONS may or may not (due to the unordered nature of Python set()) take precedence the LDFLAGS used to control BLAS linking in PETSc.

This requires a bigger fix, although probably needs discussion.

Hm. I see. So, downgrading CLT is the best solution for now since setting LDFLAGS in PETSC_CONFIGURE_OPTIONS is required only for CLT 15.

@JDBetteridge
Copy link
Member

Anecdotally CLT 14.3.1 will not run on MacOS Sonoma, I can find forum posts about this but not an official statement* from Mac. This means users may need to downgrade their OS to fix in this manner.

*I also haven't looked very hard

@Ig-dolci
Copy link
Contributor Author

Ig-dolci commented Oct 17, 2023

Anecdotally CLT 14.3.1 will not run on MacOS Sonoma, I can find forum posts about this but not an official statement* from Mac. This means users may need to downgrade their OS to fix in this manner.

*I also haven't looked very hard

Yep. The Xcode14 app is not working for Sonoma anymore, but we can still use clang14-0. I am with Sonoma and using the clang14 version here. That is a temporary fix until Xcode sorts this issue or, as you pointed out, we can try a bigger fix for Xcode15.

@Ig-dolci Ig-dolci closed this Oct 19, 2023
@Ig-dolci Ig-dolci deleted the dolci/firedrake_install_mac branch November 27, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for local_range

4 participants