Skip to content

Fixed circular import ngsPETSc #3176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dham merged 2 commits into from
Oct 18, 2023
Merged

Fixed circular import ngsPETSc #3176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c895300
Fixed circular import
Oct 16, 2023
f8913de
Fix Linting
Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions firedrake/mesh.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@

try:
import netgen
from ngsPETSc import FiredrakeMesh
except ImportError:
netgen = None
ngsPETSc = None


__all__ = [
Expand Down Expand Up @@ -2530,6 +2528,10 @@ def Mesh(meshfile, **kwargs):
if MPI.Comm.Compare(user_comm, plex.comm.tompi4py()) not in {MPI.CONGRUENT, MPI.IDENT}:
raise ValueError("Communicator used to create `plex` must be at least congruent to the communicator used to create the mesh")
elif netgen and isinstance(meshfile, netgen.libngpy._meshing.Mesh):
try:
from ngsPETSc import FiredrakeMesh
except ImportError:
raise ImportError("Unable to import ngsPETSc. Please ensure that ngsolve is installed and available to Firedrake.")
netgen_flags = kwargs.get("netgen_flags", {"quad": False, "transform": None, "purify_to_tets": False})
netgen_firedrake_mesh = FiredrakeMesh(meshfile, netgen_flags, user_comm)
plex = netgen_firedrake_mesh.meshMap.petscPlex
Expand Down