Fixes for updated PETSc #3853
Merged
Fixes for updated PETSc #3853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ksagiyam
previously approved these changes
Nov 12, 2024
connorjward
added a commit
that referenced
this pull request
Nov 25, 2024
* Add petsc_raises fixture to catch PETSc callback exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Goes with firedrakeproject/petsc#23
Key change here is the petsc4py error handler is now different and so we need a new approach for catching errors that are triggered inside a PETSc callback.
The fixture approach I use here is a bit iffy but the inability to have shared functions in pytest is a known limitation.