Skip to content

Conversation

@connorjward
Copy link
Contributor

Description

Expunges calls to mpiexec in the test suite (should be handled by pytest-mpi). Also a big refactor of test_demos and some small linting fixes.

JDBetteridge
JDBetteridge previously approved these changes Nov 14, 2024
Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way better than what was there before

@connorjward connorjward enabled auto-merge (squash) November 14, 2024 17:48
@github-actions
Copy link

github-actions bot commented Nov 14, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake complex8081 ran6500 passed1581 skipped0 failed

@github-actions
Copy link

github-actions bot commented Nov 14, 2024

TestsPassed ✅Skipped ⏭️Failed ❌
Firedrake real8087 ran7298 passed789 skipped0 failed

@connorjward connorjward disabled auto-merge November 15, 2024 08:59
@connorjward connorjward merged commit 7155630 into master Nov 15, 2024
12 checks passed
@connorjward connorjward deleted the connorjward/parallel-test-fixes branch November 15, 2024 09:00
connorjward added a commit that referenced this pull request Nov 25, 2024
* Refactor test_demos, avoid mpiexec invocation
* Fix multigrid test, __main__ is not valid when importing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants