FML: fix dunder methods and support BaseForm #4768
Merged
+68
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fml-baseform
branch
from
08b9951 to
2f55641
Compare
connorjward
requested changes
Dec 8, 2025
Contributor
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
Any chance this could get a simple unit test?
pbrubeck
force-pushed
the
pbrubeck/fml-baseform
branch
from
2f55641 to
9d6d8b1
Compare
pbrubeck
changed the title
pbrubeck
force-pushed
the
pbrubeck/fml-baseform
branch
from
9d6d8b1 to
7329ffb
Compare
connorjward
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes subtraction involving
LabelledFormby implementingLabelledForm.__neg__andLabelledForm.__rsub__Enables labelling
BaseForm