Assembly of matfree interpolation operator #4778
Conversation
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
57e5d2d to
5019974
Compare
| submat = o.petscmat.createSubMatrix(*ises) | ||
| bcs = () | ||
| return AssembledMatrix(tuple(args), bcs, submat) | ||
| return AssembledMatrix(tuple(args), submat) |
There was a problem hiding this comment.
What happened to the BCs?
There was a problem hiding this comment.
BTW, this will be fixed in https://github.com/firedrakeproject/firedrake/pull/4708/files
There was a problem hiding this comment.
BCs are an optional argument now
There was a problem hiding this comment.
Better to not change this line to avoid conflicts
update comment
leo-collins
force-pushed
the
leo/assemble-matfree-interpolate
branch
from
75de8e2 to
5464cce
Compare
connorjward
left a comment
connorjward
left a comment
There was a problem hiding this comment.
I'm only reviewing this from a high level, but this seems pretty much fine.
| def __init__( | ||
| self, | ||
| a: ufl.BaseForm | TensorBase | tuple[BaseArgument, BaseArgument], | ||
| bcs: Iterable[BCBase] | None = None, |
There was a problem hiding this comment.
Why is this allowed to be None? The default could just be ().
| return "%s(a=%r, bcs=%r)" % (type(self).__name__, | ||
| self.a, | ||
| self.bcs) | ||
| return f"{type(self).__name__}(a={repr(self.a)}, bcs={repr(self.bcs)})" |
There was a problem hiding this comment.
| return f"{type(self).__name__}(a={repr(self.a)}, bcs={repr(self.bcs)})" | |
| return f"{type(self).__name__}(a={self.a!r}, bcs={self.bcs!r})" |
| def __str__(self): | ||
| return "assembled %s(a=%s, bcs=%s)" % (type(self).__name__, | ||
| self.a, self.bcs) | ||
| return f"assembled {type(self).__name__}(a={str(self.a)}, bcs={str(self.bcs)})" |
There was a problem hiding this comment.
| return f"assembled {type(self).__name__}(a={str(self.a)}, bcs={str(self.bcs)})" | |
| return f"assembled {type(self).__name__}(a={self.a}, bcs={self.bcs})" |
| bcs: Iterable[BCBase] | None = None, | ||
| options_prefix: str | None = None, | ||
| ): | ||
| """A representation of a matrix that doesn't require knowing the underlying form. |
There was a problem hiding this comment.
Just to note, I think that it's safe to have this docstring below the class name instead of inside __init__. Not too bothered either way though.
| submat = o.petscmat.createSubMatrix(*ises) | ||
| bcs = () | ||
| return AssembledMatrix(tuple(args), bcs, submat) | ||
| return AssembledMatrix(tuple(args), submat) |
|
@connorjward Thanks for the review. I'm at a workshop this week and then on holiday again next week so I'll take a look after these. Thanks! |
Allow assembly of matfree interpolation operators by passing
mat_type="matfree".Also changes the interfaces to the matrix classes and
ImplicitMatrixContextto make them simpler.