Adding explicit children props to components#128
Merged
canova merged 3 commits intofirefox-devtools:masterfrom Aug 29, 2023
hackwater:master
Merged
Adding explicit children props to components#128canova merged 3 commits intofirefox-devtools:masterfrom hackwater:master
canova merged 3 commits intofirefox-devtools:masterfrom
hackwater:master
Conversation
In React 18's types, the implicit children prop on functional components was removed, requiring that it be explicitly defined by developers; this change adds them to the library so that Typescript projects on React 18 can continue to import the library.
✅ Deploy Preview for firefox-devtools-react-contextmenu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Haitham103
approved these changes
Aug 28, 2023
Haitham103
approved these changes
Aug 28, 2023
Haitham103
approved these changes
Aug 29, 2023
Haitham103
approved these changes
Aug 29, 2023
Haitham103
approved these changes
Aug 29, 2023
Haitham103
approved these changes
Aug 29, 2023
Haitham103
approved these changes
Aug 29, 2023
canova
approved these changes
Aug 29, 2023
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
Looks great to me, thanks for your contribution!
Member
|
@Haitham103 Please stop spamming. This is the second time I'm warning you. I will ban you from contributing if you continue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In React 18's types, the implicit children prop on functional components was removed, requiring that it be explicitly defined by developers; this change adds them to the library so that Typescript projects on React 18 can continue to import the library.